Heads up.. If there are people playing with 3.17 and btrfs at the moment then you'll want this patch, pull request for Linus below (not yet merged into the mainline so not yet a candidate for a stable release). The actual commit has a better description of the problem. https://git.kernel.org/cgit/linux/kernel/git/mason/linux-btrfs.git/commit/?h... cheers, Chris ---------- Forwarded Message ---------- Subject: [GIT PULL] Btrfs corruption fix Date: Thu, 16 Oct 2014, 03:51:13 AM From: Chris Mason <clm@fb.com> To: Linus Torvalds <torvalds@linux-foundation.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, linux-btrfs <linux-btrfs@vger.kernel.org> Hi Linus, I'm testing a pull with more fixes, but wanted to get this one out so Greg can pick it up. The corruption isn't easy to hit, you have to do a readonly snapshot and have orphans in the snapshot. But my review and testing missed the bug. Filipe has added a better xfstest to cover it. Please pull: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus Chris Mason (1) commits (+33/-36): Revert "Btrfs: race free update of commit root for ro snapshots" Total: (1) commits (+33/-36) fs/btrfs/inode.c | 36 ------------------------------------ fs/btrfs/ioctl.c | 33 +++++++++++++++++++++++++++++++++ 2 files changed, 33 insertions(+), 36 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html ----------------------------------------- -- Chris Samuel : http://www.csamuel.org/ : Melbourne, VIC
Heads up..
If there are people playing with 3.17 and btrfs at the moment then you'll want this patch, pull request for Linus below (not yet merged into the mainline so not yet a candidate for a stable release). The actual commit has a better description of the problem.
https://git.kernel.org/cgit/linux/kernel/git/mason/linux- btrfs.git/commit/?h=for- linus&id=529c9ab761315fb5bccc79176d270fd6392a8f07
Thanks for that. I think that's likely what bit me (or else there is some other unknown bug...) I was testing out 3.17-rc5 debian package as 3.16 has a bunch of bcache bugs (annoyances really - system load always >= bcache volumes) Looks like this patch missed 3.17.1. Better wait for 3.17.2 I guess... and then maybe wait some more to let others test with their data ;) James
On Thu, 16 Oct 2014 10:04:29 AM James Harper wrote:
Thanks for that. I think that's likely what bit me (or else there is some other unknown bug...) I was testing out 3.17-rc5 debian package as 3.16 has a bunch of bcache bugs (annoyances really - system load always >= bcache volumes)
Not a worry - hopefully it'll help! Josef on the btrfs list said he was hoping he could make the btrfs fsck tool fix the corruption the bug introduced.
Looks like this patch missed 3.17.1. Better wait for 3.17.2 I guess... and then maybe wait some more to let others test with their data
It's not yet a candidate for a stable release as the patch hasn't made it into the mainline kernel for 3.18 (yet). cheers, Chris -- Chris Samuel : http://www.csamuel.org/ : Melbourne, VIC
On Thu, 16 Oct 2014 09:24:43 PM Chris Samuel wrote:
It's not yet a candidate for a stable release as the patch hasn't made it into the mainline kernel for 3.18 (yet).
This fix was merged into the mainline kernel last night. -- Chris Samuel : http://www.csamuel.org/ : Melbourne, VIC
On Thu, 16 Oct 2014 09:24:43 PM Chris Samuel wrote:
It's not yet a candidate for a stable release as the patch hasn't made it into the mainline kernel for 3.18 (yet).
This fix was merged into the mainline kernel last night.
So.... 3.17.2? James
On Sun, 19 Oct 2014 03:06:23 AM James Harper wrote:
So.... 3.17.2?
If it's been sent to him correctly, and if Greg K-H accepts it (and I can't see a reason he wouldn't) then I'd guess so. cheers, Chris -- Chris Samuel : http://www.csamuel.org/ : Melbourne, VIC
On Sun, 19 Oct 2014 02:29:00 PM Chris Samuel wrote:
If it's been sent to him correctly, and if Greg K-H accepts it (and I can't see a reason he wouldn't) then I'd guess so.
Chris Mason has sent out a stable pull request to Greg and has created a branch to track them, see here: https://www.mail-archive.com/linux-btrfs@vger.kernel.org/msg38201.html cheers, Chris -- Chris Samuel : http://www.csamuel.org/ : Melbourne, VIC
On Sun, 19 Oct 2014 03:06:23 AM James Harper wrote:
So.... 3.17.2?
Just checked and there's currently no patches queued for any stable kernel release at present. You can clone this repo to keep an eye on things: git://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git cheers, Chris -- Chris Samuel : http://www.csamuel.org/ : Melbourne, VIC
participants (2)
-
Chris Samuel -
James Harper